Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary copy-X protection checking #328

Merged
merged 31 commits into from
Oct 27, 2024

Conversation

HeroponRikiBestest
Copy link
Contributor

Started work on preliminary copy-X protection checking.

@HeroponRikiBestest HeroponRikiBestest marked this pull request as ready for review October 25, 2024 04:55
Copy link
Collaborator

@TheRogueArchivist TheRogueArchivist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there are a few things with the comments that I think should be changed before merging.

@HeroponRikiBestest HeroponRikiBestest marked this pull request as draft October 25, 2024 19:03
Copy link
Collaborator

@mnadareski mnadareski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, will be waiting on @TheRogueArchivist to do a comment content check

@mnadareski mnadareski marked this pull request as ready for review October 27, 2024 03:15
Copy link
Collaborator

@TheRogueArchivist TheRogueArchivist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnadareski mnadareski merged commit 4e0442d into SabreTools:master Oct 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants